HoustonPutman commented on code in PR #2483:
URL: https://github.com/apache/solr/pull/2483#discussion_r1619190342


##########
gradle/testing/failed-tests-at-end.gradle:
##########
@@ -25,11 +25,12 @@ allprojects {
   tasks.withType(Test) { Test task ->
     afterTest { desc, result ->
       if (result.resultType == TestResult.ResultType.FAILURE) {
+        def testOrClassName = desc.name == "classMethod" ? desc.className : 
"${desc.className}.${desc.name}"
         failedTests << [
             "name": "${desc.className}.${desc.name}",

Review Comment:
   Hmm, its still probably good to have a pretty clear indication that it was a 
classMethod, right? I think it would be a bit confusing otherwise to see that 
both 
`org.apache.solr.ltr.feature.TestUserTermScoreWithQ.testUserTermScoreWithQ` and 
`org.apache.solr.ltr.feature.TestUserTermScoreWithQ` failed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to