cpoerschke commented on code in PR #2483:
URL: https://github.com/apache/solr/pull/2483#discussion_r1619145893


##########
gradle/testing/failed-tests-at-end.gradle:
##########
@@ -25,11 +25,12 @@ allprojects {
   tasks.withType(Test) { Test task ->
     afterTest { desc, result ->
       if (result.resultType == TestResult.ResultType.FAILURE) {
+        def testOrClassName = desc.name == "classMethod" ? desc.className : 
"${desc.className}.${desc.name}"
         failedTests << [
             "name": "${desc.className}.${desc.name}",

Review Comment:
   How about also changing this?
   ```suggestion
               "name": "$testOrClassName",
   ```
   
   (I spotted this only because in 
https://github.com/apache/solr/actions/runs/9274510162/job/25517863554?pr=2483 
it says _"... ERROR: The following test(s) have failed: ... 
org.apache.solr.ltr.feature.TestUserTermScoreWithQ.classMethod 
(:solr:modules:ltr) ..."_ currently.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to