epugh commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1611732329
##########
solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java:
##########
@@ -375,24 +370,11 @@ private void init(int port) {
new ServletContextHandler(server, "/solr",
ServletContextHandler.SESSIONS);
root.setResourceBase(".");
- server.addEventListener(
- new LifeCycle.Listener() {
-
- @Override
- public void lifeCycleStopping(LifeCycle arg0) {}
-
- @Override
- public synchronized void lifeCycleStopped(LifeCycle arg0) {
- if (coreContainerProvider != null) {
- coreContainerProvider.close();
- }
- }
-
+ root.addEventListener(
+ new CoreContainerProvider() {
Review Comment:
maybe worth a comment in the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
