gus-asf commented on code in PR #2474:
URL: https://github.com/apache/solr/pull/2474#discussion_r1609909368
##########
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##########
@@ -73,10 +72,7 @@
public class SolrDispatchFilter extends BaseSolrFilter implements PathExcluder
{
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
- // TODO: see if we can get rid of the holder here (Servlet spec actually
guarantees
- // ContextListeners run before filter init, but JettySolrRunner that we use
for tests is
- // complicated)
- private ServiceHolder coreService;
Review Comment:
This was the sticky bit. Before pushing I suggest you beast the tests for a
good while. My memory is that without this I got a low level of failures and or
deadlocks. The current state while apparently not perfect had a low enough
frequency that it didn't crop up. (though I don't remember exactly how long I
was beasting things either).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
