risdenk commented on code in PR #2221: URL: https://github.com/apache/solr/pull/2221#discussion_r1471409812
########## solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java: ########## @@ -169,6 +160,20 @@ public void prepare(ResponseBuilder rb) throws IOException { try { QParser parser = QParser.getParser(rb.getQueryString(), defType, req); + + SortSpec sortSpec = parser.getSortSpec(true); + rb.setSortSpec(sortSpec); + boolean someDocs = sortSpec == null || sortSpec.getCount() != 0; + + // Set field flags Review Comment: I changed this impl in 23cca04 which makes `SortSpec#includeScore` and `SolrReturnFields` smarter about `rows=0` so they never indicate they need scores. This flows into the `GET_SCORES` logic as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org