HoustonPutman commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572758958
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -54,17 +54,12 @@ public class CloudHttp2SolrClient extends CloudSolrClient {
*/
protected CloudHttp2SolrClient(Builder builder) {
super(builder.shardLeadersOnly, builder.parallelUpdates,
builder.directUpdatesToLeadersOnly);
- if (builder.httpClient == null) {
- this.clientIsInternal = true;
- if (builder.internalClientBuilder == null) {
- this.myClient = new Http2SolrClient.Builder().build();
- } else {
- this.myClient = builder.internalClientBuilder.build();
- }
- } else {
- this.clientIsInternal = false;
- this.myClient = builder.httpClient;
- }
+ this.clientIsInternal = builder.httpClient == null;
+ this.myClient = createOrGetHttpClientFromBuilder(builder);
+ this.stateProvider =
+ !builder.zkHosts.isEmpty()
Review Comment:
can you remove the `!` and just flip the values? I think it would be easier
to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
