laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572680652
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -85,14 +79,62 @@ protected CloudHttp2SolrClient(Builder builder) {
this.lbClient = new LBHttp2SolrClient.Builder(myClient).build();
}
+ private Http2SolrClient createOrGetHttpClientFromBuilder(Builder builder) {
+ return builder.httpClient != null
Review Comment:
Personally, I like the ternary notation, it makes the code less verbose but
I don't mind changing it into a more classical way. Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
