jdyer1 commented on code in PR #2374: URL: https://github.com/apache/solr/pull/2374#discussion_r1548589588
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java: ########## @@ -469,6 +531,23 @@ protected String allProcessorSupportedContentTypesCommaDelimited( .collect(Collectors.joining(", ")); } + protected static class HttpSolrClientCancellable implements Cancellable { Review Comment: I do not want to deprecate anything unless there is a replacement. But I hear and share your concern, and would like to make the API change, just not as part of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org