laminelam commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1536943305
########## solr/server/scripts/cloud-scripts/zkcli.sh: ########## @@ -13,6 +13,21 @@ log4j_config="file:$sdir/../../resources/log4j2-console.xml" solr_home="$sdir/../../solr" +# Get solr dir with fullpath Review Comment: Hi @epugh I have a new PR where I separated code instantiating _SolrZkClient_ and _CloudSolrClient_ in ZK related SolrCli _tool_ classes. The PR adds also a _SolrClassLoader_ to _CloudHttp2SolrClient Builder_ which allows to load _solr modules_ libs without relying on _solr_ and _solr.cmd_ scripts. As soon as it's approved internally will push it upstream for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
