laminelam commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1534863816
########## solr/server/scripts/cloud-scripts/zkcli.sh: ########## @@ -13,6 +13,21 @@ log4j_config="file:$sdir/../../resources/log4j2-console.xml" solr_home="$sdir/../../solr" +# Get solr dir with fullpath Review Comment: Hi Houston, I have added solr modules to _solr_ and _solr.cmd_. PS: There is another way to load the modules without touching _solr_ and _solr.cmd_ but this requires changing a lot of "_tool_" classes where _SolrZkClient_ instantiation is duplicated (the code is duplicated 12 times in 8 diff classes). I think we should extract the code instantiating the _SolrZkClient_ to a separate class as well as considering merging ZK related tool classes. @HoustonPutman @epugh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
