aparnasuresh85 commented on PR #2363: URL: https://github.com/apache/solr/pull/2363#issuecomment-2015349982
> > The reason I did not make the logic consistent across both providers is because BaseHttpClusterStateProvider, where the logic for getState() is implemented for the http version, checks all livenodes for presence of the collection/collectionRef via a SolrQuery. I felt that was comprehensive enough. > > OMG I didn't look; so glad to see the correct implementation there already :-) > > Please add a CHANGES.txt for the next 9.x version under Improvements. I suppose this may be ready to merge. > > In a separate PR, I'd like to see most waitForState calls that follow collection creation to be removed. I pushed a commit to exclude waitForState() calls after collection creation. Will do another pass to identify other hidden calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
