aparnasuresh85 opened a new pull request, #2363:
URL: https://github.com/apache/solr/pull/2363

   …ted cluster state
   
   https://issues.apache.org/jira/browse/SOLR-17153
   
   <!--
   _(If you are a project committer then you may remove some/all of the 
following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system 
for Solr:
   
   * https://issues.apache.org/jira/projects/SOLR
   
   For something minor (i.e. that wouldn't be worth putting in release notes), 
you can skip JIRA. 
   To create a Jira issue, you will need to create an account there first.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * SOLR-17153: CloudSolrClient should not throw "Collection not found" with 
an out-dated ClusterState
   
   SOLR must be fully capitalized. A short description helps people scanning 
pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly 
updated with code review comments and commits. -->
   
   
   # Description
   
   At present, when CloudSolrClient is instructed to send a request to a 
collection it deems non-existent due to its outdated local ClusterState view, 
it fails locally, which is undesired. This failure should be addressed. 
Moreover, many SolrCloud tests should remove their waitForState calls following 
collection creation. Matters concerning other stale states are not addressed 
here.
   
   Similar changes will be required on the server side to handle "Collection 
Not Found" errors resulting from outdated cluster state.
   
   # Solution
   
   If neither CloudSolrClient nor HttpSolrCall (server) can locate a 
collection, trigger a forced fetch of the collection from ZooKeeper and update 
the local cluster state accordingly.
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch 
implements the feature or solves the problem.
   Change existing tests to eliminate **waitForState()** and 
**waitForActiveCollection()** calls that were previously present after 
collection creation. These calls are unnecessary due to the enhancements 
introduced in this PR. All modified tests have been thoroughly verified to 
ensure their successful execution.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [X] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [X] I have developed this patch against the `main` branch.
   - [X] I have run `./gradlew check`.
   - [] I have added tests for my changes.
   - [] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to