alessandrobenedetti commented on PR #2348: URL: https://github.com/apache/solr/pull/2348#issuecomment-2007629216
Thanks @cpoerschke for your feedback! I'll push a commit soon with changes accordingly to your suggestions. In terms of documentation I am inclined to add a line in the Learning To Rank section only. Not because I don't want to add it in the other two sections you mentioned (Partial Results and TImeAllowed), but because I believe those two sections should be enriched with all the components they support, explaining what happens for each of the components if the limit is reached. This will include also what happens in Learning To Rank but I see this general improvement as a separate documentation Pull Request. I'll keep iterating on this PR for a bit, so additional comments are welcome. When closing I'll also create the Jiras with all the children tasks identified (refactor of ScoreFeatures, Double label MaybeShouldExit and better documentation for timeAllowed and partial results) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
