cpoerschke commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530221741
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java:
##########
@@ -234,6 +236,13 @@ protected static boolean scoreSingleHit(
scorer.getDocInfo().setOriginalDocScore(hit.score);
hit.score = scorer.score();
+ if (QueryLimits.getCurrentLimits()
+ .maybeExitWithPartialResults(
+ "Learning To Rank rescoring -"
+ + " The full reranking didn't complete."
+ + " If partial results are tolerated the reranking got
reverted and all documents preserved their original score and ranking.")) {
Review Comment:
subjective, code complexity/simplicity vs. user/operational friendliness:
the _"If partial results are tolerated"_ probably is 'knowable' at this point
in the code i.e. if the info/knowledge were to passed down to this API then the
wording could be differentiated here i.e. no 'if' qualifier in the wording.
edit: I guess this is not specific to LTR actually and maybe we could have a
variant of the `maybeExitWithPartialResults` API even that supports two labels,
one for when partial results are tolerated and one for when they are not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
