jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1521445967
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##########
@@ -64,6 +62,12 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+/**
+ * A SolrClient implementation that communicates to a Solr server using the
built-in Java 11+ Http
+ * Client. This client is targeted for those users who wish to minimize
application dependencies.
+ * This client will connect to solr using Http/2 but can seamlessly downgrade
to Http/1.1 when
+ * connecting to Solr hosts running on older versions.
+ */
public class HttpSolrJdkClient extends HttpSolrClientBase {
Review Comment:
Let's go with `HttpJdkSolrClient`. Putting *Jdk* first emphasis an
implementation detail over what the class actually does. It also would be at
odds with how our other clients are named. I agree having *Jdk* between *solr*
and *client* is a bit awkward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
