dsmiley commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-1978009974

   >On a side note, How about we rethink the design decorating the request. 
Right now, we recreate the Http2SolrClient to override socketTimeout and 
connTimeout.
   
   Which is a fine approach, IMO.  They are light.
   
   >  Instead of recreating Http2SolrClient, we introduced another method which 
would override Timeouts.
   
   I was going to mention something like this but I'm opposed to another 
request() method like you propose.  Instead, SolrRequest could have the 
timeouts.  It already has other methods of a low-ish level like headers, URL, 
preferred nodes.  Just keep in mind we have 2 clients and another on the way so 
2-3 places to update to consider this timeout.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to