dsmiley commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-1977700604

   Thanks for digging into the authentication issue further; this is shining a 
light on an issue I was vaguely aware of but now I can see it directly.  And 
I'm so glad there are tests; I thought it wasn't tested.  Can you name one 
please?
   
   One thing will help; stop excessive creation of new SolrClient instances 
when we can re-use the same one that is configured with this auth listener 
thing.  Thus don't have fields on classes that hold an HttpClient (we'll deem 
this bad/questionable practice); instead hold an Http2SolrClient.  If due to 
customized timeouts we need a new Http2SolrClient, we could ensure that the 
builder withHttpClient(http2SolrClient) copies listeners (and anything else 
like an executor; why not).  That could be its own JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to