cpoerschke commented on PR #2248: URL: https://github.com/apache/solr/pull/2248#issuecomment-1973204347
> Observation: I don't think we need the concurrent DocSet builder (the one from Netflix). Couldn't we build segment level FixedBitSets (no safety issue) and then at the end combine into a master FixedBitSet so that we have our DocSet? It could even be made to be long-aligned, and thus the final aggregation is just copying longs with System.arraycopy (no doc iteration! or long shifting). The boundary long would be XOR. @dsmiley - is something like https://github.com/apache/solr/pull/2248/commits/34c7db09e08693a79d87eaa6e43ad6f5aacbc342 what you had in mind here? For starters modelled on https://github.com/apache/lucene/blob/releases/lucene/9.10.0/lucene/test-framework/src/java/org/apache/lucene/tests/search/FixedBitSetCollector.java i.e. no `System.arraycopy` etc. as yet. @chatman - i hope you don't mind me adding commits to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
