tboeghk opened a new pull request, #2310: URL: https://github.com/apache/solr/pull/2310
https://issues.apache.org/jira/browse/SOLR-17185 # Description Opening up the class `ValueAugmenter` in the `ValueAugmenterFactory` to `public` access level eases the creation of custom document transformers. Currently, we have to place our custom document transformers in the `org.apache.solr.response.transform` package to be able to access the package private `ValueAugmenter`. Changing the visibility to `public` enables building custom document transformers very slim and quick like the following one in any package: ```java public class CollectionAugmenterFactory extends TransformerFactory { @Override public DocTransformer create(String field, SolrParams params, SolrQueryRequest req) { String v = ComponentUtils.getCollectionNameFrom(req.getCore()).orElse("[unknown]"); return new ValueAugmenterFactory.ValueAugmenter(field, v); } } ``` # Solution Change the visibility of `ValueAugmenter` from package private to `public`. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
