gerlowskija commented on code in PR #2243:
URL: https://github.com/apache/solr/pull/2243#discussion_r1479783759


##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -412,7 +412,8 @@ public CoreContainer(NodeConfig config, CoresLocator 
locator, boolean asyncSolrC
         new OrderedExecutor(
             cfg.getReplayUpdatesThreads(),
             ExecutorUtil.newMDCAwareCachedThreadPool(

Review Comment:
   > I may remove the capacity parameter and always use Integer.MAX_VALUE for 
the queue capacity.
   
   I suspect you're right that this was an oversight or mistake.  But I'd file 
a separate ticket for changing this if you're interested.  It's likely a safe 
change, but it seems like something we'd want to "bake" for longer before it 
goes into a release.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to