psalagnac commented on code in PR #2243:
URL: https://github.com/apache/solr/pull/2243#discussion_r1478841079


##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -412,7 +412,8 @@ public CoreContainer(NodeConfig config, CoresLocator 
locator, boolean asyncSolrC
         new OrderedExecutor(
             cfg.getReplayUpdatesThreads(),
             ExecutorUtil.newMDCAwareCachedThreadPool(

Review Comment:
   I did not change the behavior here, but to be honest, I don't get why we 
create an executor with a bounded queue that have same capacity than the number 
of threads. By default, number of threads is number of processors available to 
the JVM.
   
   If there is an agreement this queue should be unbounded too, I may remove 
the capacity parameter and always use `Integer.MAX_VALUE` for the queue 
capacity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to