magibney commented on code in PR #1557:
URL: https://github.com/apache/solr/pull/1557#discussion_r1539802827
##########
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##########
@@ -372,7 +372,7 @@ public void doc(int docId, StoredFieldVisitor visitor)
throws IOException {
Document cached = doc(docId);
visitFromCached(cached, visitor);
} else {
- searcher.getIndexReader().document(docId, visitor);
+ searcher.getIndexReader().storedFields().document(docId, visitor);
Review Comment:
> Perhaps we change the contract of SolrIndexSearcher.getDocFetcher (which I
added years ago BTW) to return a new instance (with a storedFields of course)
that is not thread-safe.
75e095552e51302096883a96a93cf9197140f3a3 implements this approach. Feedback
welcome; feel free to revert or rework as you see fit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
