epugh commented on code in PR #2229:
URL: https://github.com/apache/solr/pull/2229#discussion_r1471051440
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##########
@@ -237,8 +237,10 @@ public Map<String, SolrPackageInstance>
getPackagesDeployed(String collection) {
NamedList<Object> result =
solrClient.request(
new GenericSolrRequest(
- SolrRequest.METHOD.GET,
- PackageUtils.getCollectionParamsPath(collection) +
"/PKG_VERSIONS"));
+ SolrRequest.METHOD.GET,
+ PackageUtils.getCollectionParamsPath(collection) +
"/PKG_VERSIONS")
+ .setRequiresCollection(
+ false) /* Making a collection request, but already baked
into path */);
Review Comment:
Do we have JIRA tickets to track removing GSR? I think my concern is that
we forget about this follow up refactoring and it never happens. Although,
maybe we *would* fix it by just having the better v2 SolrRequest impl. Let's
keep moving forward! And not have this PR grow too much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
