cpoerschke commented on code in PR #2069: URL: https://github.com/apache/solr/pull/2069#discussion_r1391086796
########## solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc: ########## @@ -32,8 +32,25 @@ Setting the `shards.tolerant=true` parameter on requests can help with graceful circuit breaker thresholds are reached on some nodes. See the <<shards.tolerant Parameter>> for details. == Circuit Breaker Configurations -All circuit breaker configurations are listed as independent `<circuitBreaker>` entries in `solrconfig.xml` as shown below. -A circuit breaker can register itself to trip for query requests and/or update requests. By default only search requests are affected. A user may register multiple circuit breakers of the same type with different thresholds for each request type. +Circuit breakers can be configured globally for the entire node, or for each collection individually, or a combination. Per-collection circit breakers take precedence over global circuit breakers. Review Comment: Thanks for the example, that helps with thinking through the scenarios :-) > ... e.g. QUERY MEM 90% globally and QUERY MEM 70% for the collection, then a request to that collection will trip at 70%, not 95, since the "local" value takes precedence. ... That makes me wonder actually, should we consider what happens if someone (mis)configures > ... e.g. QUERY MEM 70% globally and QUERY MEM 90% for the collection ... i.e. in that case it will still trip at 70% and the 90% threshold is either a mistake or misunderstanding, or possibly some sort of transitional addition before the global threshold is removed or something. Or put another way, it's always the lowest threshold that takes precedence? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
