cpoerschke commented on code in PR #2069: URL: https://github.com/apache/solr/pull/2069#discussion_r1391036941
########## solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc: ########## @@ -32,8 +32,25 @@ Setting the `shards.tolerant=true` parameter on requests can help with graceful circuit breaker thresholds are reached on some nodes. See the <<shards.tolerant Parameter>> for details. == Circuit Breaker Configurations -All circuit breaker configurations are listed as independent `<circuitBreaker>` entries in `solrconfig.xml` as shown below. -A circuit breaker can register itself to trip for query requests and/or update requests. By default only search requests are affected. A user may register multiple circuit breakers of the same type with different thresholds for each request type. +Circuit breakers can be configured globally for the entire node, or for each collection individually, or a combination. Per-collection circit breakers take precedence over global circuit breakers. Review Comment: Hmm, perhaps I'm misunderstanding the code then ... ... so `getCombinedMap` handles the scenario where both per-collection and global are present by concatenating the lists and the per-collection ones are placed before the global ones: https://github.com/apache/solr/blob/e740123546c7f20c6728df42d493e11f93dc8c79/solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java#L267-L279 ... `checkTripped` checks all the circuit breakers of the request type in question but if a tripping one is found it still continues to check the remaining ones because they could have tripped too: https://github.com/apache/solr/blob/e740123546c7f20c6728df42d493e11f93dc8c79/solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java#L168-L181 So my understanding then is that there is ordering in the checks but no precedence or conflict as such because both per-collection and global circuit breakers are always checked? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
