janhoy commented on code in PR #2050:
URL: https://github.com/apache/solr/pull/2050#discussion_r1377354232


##########
solr/api/build.gradle:
##########
@@ -55,8 +56,24 @@ dependencies {
     testImplementation 'org.apache.lucene:lucene-test-framework'
 }
 
+// Ensure the OAS is available to other modules who want to generate code 
(i.e. solrj)
 artifacts {
     openapiSpec resolve.outputDir, {
         builtBy resolve
     }
 }
+
+// Non-Java client generation tasks below:
+
+task buildJSClient(type: 
org.openapitools.generator.gradle.plugin.tasks.GenerateTask) {
+  generatorName.set("javascript-closure-angular")

Review Comment:
   Given we want to dog-food our current Admin UI first, perhaps the pure 
`javascript` client fits best. But for sure, once we plan to release something 
for customer use, TS bindings would likely be requested. Do we know whether the 
"typescript" generator is identical to the `javascript` generator plus types, 
or are they separate templates?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to