MarcusSorealheis commented on code in PR #2050:
URL: https://github.com/apache/solr/pull/2050#discussion_r1376845299
##########
solr/api/build.gradle:
##########
@@ -55,8 +56,24 @@ dependencies {
testImplementation 'org.apache.lucene:lucene-test-framework'
}
+// Ensure the OAS is available to other modules who want to generate code
(i.e. solrj)
artifacts {
openapiSpec resolve.outputDir, {
builtBy resolve
}
}
+
+// Non-Java client generation tasks below:
+
+task buildJSClient(type:
org.openapitools.generator.gradle.plugin.tasks.GenerateTask) {
+ generatorName.set("javascript-closure-angular")
Review Comment:
@gerlowskija a few thoughts:
1. I strongly recommend to use the `typescript` or `javascript` generators
rather than one that ties users to a specific vendor. Specifically, AngularJS
is a deprecated project and the version Solr was built on doesn't even exist
anymore. The Angular that sort of lives on is written in Typescript.
2. The `typescript` option is listed in the docs as `experimental`, though I
doubt it would be very experimental and `typescript-node` is labeled `stable`.
In reality, both are probably more stable than the`javascript` option. The
`javascript` option may offer a slightly lower barrier to entry for future
contributors for now, while the `typescript` one will have a growing ecosystem
and offer far better maintainability in the future.
3. The biggest benefits of the Typescript language are maintenance and
developer experience, especially for a team of Java users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
