janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1310867905
##########
solr/solr-ref-guide/modules/deployment-guide/pages/jwt-authentication-plugin.adoc:
##########
@@ -85,6 +85,8 @@ jwk ; As an alternative to `jwksUrl` you may
provide a static J
iss ; Unique issuer id as configured on the IdP. Incoming
tokens must have a matching `iss` claim. Also used to resolve issuer when
multiple issuers configured. ; Auto configured if `wellKnownUrl` is
provided
aud ; Validates that the `aud` (audience) claim equals this
string ; Uses `clientId` if configured
authorizationEndpoint; The URL for the Id Provider's authorization endpoint ;
Auto configured if `wellKnownUrl` is provided
+tokenEndpoint; The URL for the Id Provider's token endpoint ; Auto configured
if `wellKnownUrl` is provided
+authorizationFlow; Specifies the OAuth 2.0 flow to be used. Supported flows
are 'implicit_flow' and 'code_pkce' (for authorization code with 'Proof Key for
Code Exchange'). Note: 'implicit_flow' is deprecated and it is highly
recommended to use 'code_pkce' instead. ; implicit_flow
Review Comment:
`implicit_flow` --> `implicit`?
##########
solr/server/etc/jetty.xml:
##########
@@ -99,6 +100,7 @@
</New>
</Arg>
</Call>
Review Comment:
Do we need a fallback CSP header for all API endpoints?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
