gerlowskija commented on PR #1793: URL: https://github.com/apache/solr/pull/1793#issuecomment-1654598386
Alright - made some decent enough progress addressing review feedback, etc. that I'm taking this out of "Draft" mode! There's still one big unanswered question that's come up so far: if we're adding Jackson to SolrJ do we want to add it as a "normal" dependency, or do we want to shade to save SolrJ users any potential version conflicts? But of course there's still lots I'd appreciate feedback. Especially on the template for the generated files - do these SolrRequests and Responses look reasonable to folks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org