gerlowskija commented on PR #1793: URL: https://github.com/apache/solr/pull/1793#issuecomment-1654436038
> My motivation is to provide an optimal experience to users -- a single JAR. I'm not sure I understand -- SolrJ has never been a single jar. It uses a bunch of Jetty libs, SLF4J, Apache HttpComponents, Jackson (pending, with this PR). Do you see the 'api' dep being more onerous than those in some way? Or are you envisioning a future where SolrJ is truly dependency-less? > Google search turned up this promising information Thanks for the link! Actually, we're already doing something similar to the accepted answer here, in that we're declaring compileJava to be dependent on our generation task (openApiGenerate). But the applicability stops there unfortunately: it's just two very different kinds of generation. The SO question is trying to do FMPP generation, which essentially acts like a C-preprocessor and does some primitive string-manipulation and macro-expansion. The input is raw source files - or really any text you feed it, it doesn't even have to be code. OTOH, the swagger-gradle-plugin we're using requires already-compiled class files as input. They're just very different animals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
