bszabo97 commented on code in PR #1682: URL: https://github.com/apache/solr/pull/1682#discussion_r1224122254
########## solr/core/src/java/org/apache/solr/handler/admin/api/GetSchemaZkVersionAPI.java: ########## @@ -0,0 +1,69 @@ +package org.apache.solr.handler.admin.api; + +import static org.apache.solr.client.solrj.impl.BinaryResponseParser.BINARY_CONTENT_TYPE_V2; + +import com.fasterxml.jackson.annotation.JsonProperty; +import java.lang.invoke.MethodHandles; +import javax.inject.Inject; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import org.apache.solr.api.JerseyResource; +import org.apache.solr.cloud.ZkSolrResourceLoader; +import org.apache.solr.core.SolrCore; +import org.apache.solr.jersey.PermissionName; +import org.apache.solr.jersey.SolrJerseyResponse; +import org.apache.solr.schema.ManagedIndexSchema; +import org.apache.solr.schema.ZkIndexSchemaReader; +import org.apache.solr.security.PermissionNameProvider; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Path("/{a:cores|collections}/{collectionName}/schema") +public class GetSchemaZkVersionAPI extends JerseyResource { Review Comment: I was doing the extension more because `GetSchemaFieldAPI` also uses the index schema and not because we inherit the path as well. I was thinking that if we need to add the Solr core here anyways it is nicer to only have that one attribute than both Solr core and Index schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org