gerlowskija commented on PR #1682: URL: https://github.com/apache/solr/pull/1682#issuecomment-1580842553
> I tried to create unit test for endpoint /zkversion I was not able to mock ManagedIndexSchema class since it is a final class. I have tried several solutions found online but I was not happy with any of those Yeah, I've run into these sort of restrictions at different points as well. Unfortunately there's no easy workaround that I know of. I think more recent versions of Mockito have a way to mock 'final' classes. I tried to upgrade the Mockito that Solr uses at some point but ran into some dep conflicts that were tricky to resolve. If the test would add enough value to justify the effort, we could look at removing the 'final' modifier from ManagedIndexSchema. I could be wrong, but I don't think anyone would object to that as long as there's no especially compelling reason for MIS to be "final". I can take that on and get back to you shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
