[ https://issues.apache.org/jira/browse/SOLR-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727605#comment-17727605 ]
Jason Gerlowski commented on SOLR-16720: ---------------------------------------- [~stillalex] found a fix for the JWTAuthPluginIntegrationTest failure that this patch caused the last time it was merged. I merged this PR (with the test fix) to 'main' prior to the long weekend, and runs look at least as good as they did pre-merge. It's hard to be too confident here since JwtAPIT has so much baseline flakiness 😬, but... Anyway, I'm going to backport to branch_9x and close this out. Will continue to keep an eye out for any related failures, of course... > PKI should decorate outgoing requests at "sending", not "enqueueing" time > ------------------------------------------------------------------------- > > Key: SOLR-16720 > URL: https://issues.apache.org/jira/browse/SOLR-16720 > Project: Solr > Issue Type: Improvement > Components: Authentication > Affects Versions: 9.2 > Reporter: Jason Gerlowski > Priority: Minor > Attachments: SOLR-16720-reproduce.patch, Screen Shot 2023-04-07 at > 9.16.30 AM.png, reproduce.sh > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Currently, PKIAuthenticationPlugin decorates intra-node requests using an > 'onQueue' lifecycle hook, which is triggered when the request is enqueued for > processing by the (asynchronous) Jetty http client. > This works great on many systems. However on heavily loaded clusters the > time between Jetty "queueing" the request and it actually being sent out can > be non-negligible. If this gap becomes wide enough, the TTL encoded into the > PKI auth header might have substantially or fully expired by the time the > receiving node gets the request. > We should experiment with moving PKI header decoration to the 'onBegin' hook > instead, which fires much closer to the actual request-send time on heavily > loaded servers. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org