[ https://issues.apache.org/jira/browse/SOLR-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709680#comment-17709680 ]
Kevin Risden commented on SOLR-16720: ------------------------------------- Specifically looking at org.apache.solr.security.jwt.JWTAuthPluginIntegrationTest.testMetrics - There is a big spike since April 5th when this was merged. There is a change of passThrough=4 -> passThrough=2 which idk exactly what that means but there are 2 fewer requests. This seems to potentially make sense with this change. > PKI should decorate outgoing requests at "sending", not "enqueueing" time > ------------------------------------------------------------------------- > > Key: SOLR-16720 > URL: https://issues.apache.org/jira/browse/SOLR-16720 > Project: Solr > Issue Type: Improvement > Components: Authentication > Affects Versions: 9.2 > Reporter: Jason Gerlowski > Priority: Minor > Attachments: SOLR-16720-reproduce.patch, Screen Shot 2023-04-07 at > 9.16.30 AM.png, reproduce.sh > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, PKIAuthenticationPlugin decorates intra-node requests using an > 'onQueue' lifecycle hook, which is triggered when the request is enqueued for > processing by the (asynchronous) Jetty http client. > This works great on many systems. However on heavily loaded clusters the > time between Jetty "queueing" the request and it actually being sent out can > be non-negligible. If this gap becomes wide enough, the TTL encoded into the > PKI auth header might have substantially or fully expired by the time the > receiving node gets the request. > We should experiment with moving PKI header decoration to the 'onBegin' hook > instead, which fires much closer to the actual request-send time on heavily > loaded servers. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org