[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1645: SOLR-16801: Set previous context class loader after loading plugin

[via GitHub]

sonatype-lift[bot] commented on code in PR #1645:
URL: https://github.com/apache/solr/pull/1645#discussion_r1195392383

##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -746,12 +746,22 @@ private void registerV2ApiIfEnabled(Class<? extends 
JerseyResource> clazz) {
       reason =
           "Set the thread contextClassLoader for all 3rd party dependencies 
that we cannot control")
   public void load() {
+    final ClassLoader originalContextClassLoader = 
Thread.currentThread().getContextClassLoader();
+    try {
+      // Set the thread's contextClassLoader for any plugins that are loaded 
via Modules or Packages
+      // and have dependencies that use the thread's contextClassLoader
+      Thread.currentThread().setContextClassLoader(loader.getClassLoader());
+      loadInternal();

Review Comment:
   <picture><img alt="7% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg";></picture>
   
   <b>*THREAD_SAFETY_VIOLATION:</b>*  Unprotected write. Non-private method 
`CoreContainer.load()` indirectly writes to field 
`noggit.JSONParser.devNull.buf` outside of synchronization.
    Reporting because another access to the same memory occurs on a background 
thread, although this access may not.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org