thomaswoeckinger commented on PR #1645:
URL: https://github.com/apache/solr/pull/1645#issuecomment-1549808018
> So there might be plugins that aren't authentication that might need the
Solr classloader on initialization. Is there are issue doing this `try {}
finally {}` in `load()` instead of in `initializeAuthentication()`?
>
No issue, it simply has to be decided if the usage of a custom context class
loader should be as isolated as possible or not.
Both ways will work.
> We could also just do this `try {} finally {}` logic in
`EmbeddedSolrServer. load(CoreContainer cc)`. That way it works for embedded
use cases. I'm not sure if theres any gain to solving this outside of the
embedded use case.
Sure, but i think it would be better to have a defined scope where this
context class loader should/must be active.
At the end someone has to decide it, personally i would only use a different
context class loader for the parts where it is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
