[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718127#comment-17718127
]
Jan Høydahl commented on SOLR-7871:
-----------------------------------
I put in some effort initially here, but I think the pathces from 2017/18 may
be the wrong approach. It starts a Java process to parse the config file
(attempting back compat with existing formats), and then outputs a string for
the bin/solr(.cmd) script to evaluate/execute to set the variables, to avoid
forking a new Java process from the first. I think we can do better.
bq. I cringe a little when someone suggests yaml.
I don't think it should be a goal in itself to unify all config in one format.
If we believe the new "node config" should be YML due to various good reasons,
then it should be chosen.
But perhaps we should be more ambitious than to replace solr.in.sh with a
better format. Perhaps we should replace both solr.xml and solr.in.sh/cmd with
this new "node config file".
The end goal should be that bin/solr mostly is a wrapper around SolrCLI java
code, plus figuring out low level Java params like memory and GC. All
application-level config should be parsed by Java.
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Labels: bin/solr
> Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
