[ https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718070#comment-17718070 ]
David Smiley commented on SOLR-7871: ------------------------------------ I read a good portion of the comments here (ultimately being mostly irrelevant to Eric's proposal; it's ok). It's a shame to see something that's probably 99% done, and that which took a lot of discussion / collaboration, ultimately sit here idle. SIP-6 didn't happen either. Should the work be updated and merged into v10 any way? As I understand it, we've been improving our testing of bin/solr scripts more via BATS. I don't think this issue should be distracted by the possibility of a Solr mode with separate config files, which is an existing jira issue and already has your idea for this :) SOLR-15875 > Platform independent config file instead of solr.in.sh and solr.in.cmd > ---------------------------------------------------------------------- > > Key: SOLR-7871 > URL: https://issues.apache.org/jira/browse/SOLR-7871 > Project: Solr > Issue Type: Improvement > Components: scripts and tools > Affects Versions: 5.2.1 > Reporter: Jan Høydahl > Assignee: Jan Høydahl > Priority: Major > Labels: bin/solr > Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, > SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, > SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, > SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch > > > Spinoff from SOLR-7043 > The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable > batch files, but all they do is to set environment variables for the start > scripts on the format {{key=value}} > Suggest to instead have one central platform independent config file e.g. > {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by > {{SolrCLI.java}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org