stillalex commented on PR #1504:
URL: https://github.com/apache/solr/pull/1504#issuecomment-1503952520
Status on current PR:
- added the version check on additions to fail in case we are not leader
and version = 0. (to match delete flows)
- changed error status from BAD_REQUEST to INVALID_STATE to allow for
retries. I was able to verify retries are happening [0]
- removed a 'cmd' variable - this is just minor readability refactoring, I
tried to avoid changing the code as much as possible
- updated the ShardSplitTest to keep track of exceptions happening during
the concurrent adds and deletes and fail if needed.
Things I did not do
- gave up on trying to use `isSubShardLeader ` to allow 'some' updates.
left a comment above with the code snippet just in case anyone wants to review
it
- noticed the setupRequest() method is usually called twice, I think this
is easy to fix with a basic flag, I can add it if it doesn't grow the PR too
much, or it can be done on a followup PR.
Thank you @dsmiley for the continued reviews and pointers!
[0]
```
11027 INFO (Thread-43) [] o.a.s.c.s.i.CloudSolrClient Request to collection
[collection1] failed due to (510)
org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException: Error
from server at http://127.0.0.1:62183/k_fff/wc/collection1: missing _version_
on update from leader, retry=0 maxRetries=5 commError=false errorCode=510
11027 WARN (Thread-43) [] o.a.s.c.s.i.CloudSolrClient Re-trying request to
collection(s) [collection1] after stale state error from server.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
