epugh commented on PR #1496: URL: https://github.com/apache/solr/pull/1496#issuecomment-1488737279
> @risdenk going to comment here on `TestRandomFlRTGCloud`. > > That test does some "interesting" things in randomizing things that is actually quite different then other tests (and indeed may have some things like it's use of various `FlValidator` classes that we may want to use elsewhere).. The part I struggled with is that it randomly picks between `wt` JavaBin, Json, and XML, so I created SolrClients using the builder for each one. Those can be pointed at specific nodes... I just tweaked the Javadocs a bit to try and better explain: > > ``` > * returns a random SolrClient -- either a CloudSolrClient, or an HttpSolrClient pointed at a node > * in our cluster. We have different CLIENTS based on their wt setting for each node. > ``` > > Honestly, I do find it a bit convoluted.. The test passes, but I don't love it. If you have some ideas on how to make it less convoluted, I'd love that ;-) Okay, I've made some changes.. I'd love another review, and if you are good with it, then we are ready to merge to main! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
