epugh commented on code in PR #1496:
URL: https://github.com/apache/solr/pull/1496#discussion_r1151742064
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java:
##########
@@ -116,12 +114,23 @@ protected ConcurrentUpdateSolrClient(Builder builder) {
this.streamDeletes = builder.streamDeletes;
this.connectionTimeout = Math.toIntExact(builder.connectionTimeoutMillis);
this.soTimeout = Math.toIntExact(builder.socketTimeoutMillis);
- this.stallTime = Integer.getInteger("solr.cloud.client.stallTime", 15000);
- if (stallTime < pollQueueTime * 2) {
+ this.pollQueueTimeMillis = builder.pollQueueTime;
+ this.stallTimeMillis = Integer.getInteger("solr.cloud.client.stallTime",
15000);
+
+ // make sure the stall time is larger than the polling time
+ // to give a chance for the queue to change
+ int minimalStallTime = pollQueueTimeMillis * 2;
+ if (minimalStallTime > this.stallTimeMillis) {
+ this.stallTimeMillis = minimalStallTime;
+ }
Review Comment:
What I found was that the deprecated method setPollQueueTime is being used..
and that the logic iin the method needed to be preserved, so then I moved
it... I did want to have an extra set of eyes on it ;-). WOuld you like me
to cherry-pick the commit into a new PR???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
