stillalex commented on PR #1459: URL: https://github.com/apache/solr/pull/1459#issuecomment-1470566279
to answer the questions you posted: > Does this PR change any of the API responses (for those APIs which preexisted this PR? It doesn't look like it (which is good), but just wanted to double check. hmm. I did not touch the v1 apis, but I did remove the v2 collections support. let me know if this was not the right decision > I'm a little ambivalent about the response for GET /api/aliases/aName/properties/foo (which looks to be an API that's brand new to this PR?). Do we need to include "property": "foo" - presumably the user already knows which replica property they requested? I don't feel strongly in either direction here, just wondering aloud... I think I agree to remove it. you are right, doesn't feel like it's adding too much value > Does the v2 code need to support "deleting" a property via empty-string? It legitimately may because of the way that the v1 code is now structured to call into v2. But it'd be a nice thing to avoid bringing into v2, since v2 has an explicit DELETE API for that purpose now. I'm using much of the preexisting code, it might not be possible to change the apis to this level. plus if you are using the bulk property update, there would be no way to remove more properties in one go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
