gerlowskija commented on PR #1459: URL: https://github.com/apache/solr/pull/1459#issuecomment-1469818743
Hey Alex, thanks for the PR! A few comments/questions on the v2 endpoints themselves (since you summarized them in a comment above): 1. Does this PR change any of the API responses (for those APIs which preexisted this PR? It doesn't look like it (which is good), but just wanted to double check. 2. I'm a little ambivalent about the response for `GET /api/collections/cName/replica/rName/properties/foo` (which looks to be an API that's brand new to this PR?). Do we need to include `"property": "foo"` - presumably the user already knows which replica property they requested? I don't feel strongly in either direction here, just wondering aloud... 3. Does the v2 code need to support "deleting" a property via empty-string? It legitimately may because of the way that the v1 code is now structured to call into v2. But it'd be a nice thing to avoid bringing into v2, since v2 has an explicit DELETE API for that purpose now. That's all on the endpoints. Will leave comments on the code itself inline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
