vinayakphegde commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1125349206
##########
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##########
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory, DirContext dirC
throws IOException {
MMapDirectory mapDirectory = new MMapDirectory(Path.of(path), lockFactory,
maxChunk);
try {
- mapDirectory.setUseUnmap(unmapHack);
+ System.setProperty(MMapDirectory.ENABLE_UNMAP_HACK_SYSPROP,
String.valueOf(unmapHack));
Review Comment:
you mean something like this?
```
@Override
protected Directory create(String path, LockFactory lockFactory,
DirContext dirContext)
throws IOException {
MMapDirectory mapDirectory = new MMapDirectory(Path.of(path),
lockFactory, maxChunk);
log.warn("to disable the unmap hack globally, see this Lucene
documentation" +
"
https://lucene.apache.org/core/9_5_0/core/org/apache/lucene/store/MMapDirectory.html#ENABLE_UNMAP_HACK_SYSPROP";);
mapDirectory.setPreload(preload);
return mapDirectory;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
