vinayakphegde commented on PR #1360: URL: https://github.com/apache/solr/pull/1360#issuecomment-1453164773
tried to address all the issues/comments except "performance degradation for any query that isn't using timeouts" mentioned by @dsmiley now, only `org.apache.solr.search.TestComplexPhraseQParserPlugin > testPhraseHighlighter` test is failing ``` org.apache.solr.search.TestComplexPhraseQParserPlugin > testPhraseHighlighter FAILED java.lang.AssertionError: REQUEST FAILED: xpath=//lst[@name='1']/arr[@name='name']/str[.='<em>john</em> <em>smith</em> <em>smith</em> <em>john</em>'] xml response was: <?xml version="1.0" encoding="UTF-8"?> <response> <lst name="responseHeader"><int name="status">0</int><int name="QTime">0</int></lst><result name="response" numFound="2" start="0" numFoundExact="true"><doc><str name="id">1</str></doc><doc><str name="id" >2</str></doc></result><lst name="highlighting"><lst name="1"/><lst name="2"/></lst> </response> request was:q=name:"(john+johathon)+smith"&defType=complexphrase&qt=&hl=true&fl=id&hl.requireFieldMatch=false&hl.usePhraseHighlighter=false&hl.fragsize=0&start=0&hl.fl=name&rows=200 at __randomizedtesting.SeedInfo.seed([3D5488D220BF1F0:B454EA75135D9B1]:0) at org.junit.Assert.fail(Assert.java:89) at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:1025) at org.apache.solr.search.TestComplexPhraseQParserPlugin.testPhraseHighlighter(TestComplexPhraseQParserPlugin.java:216) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758) at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946) at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982) at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996) ``` looking into it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org