risdenk commented on code in PR #1363: URL: https://github.com/apache/solr/pull/1363#discussion_r1109886452
########## solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java: ########## @@ -296,6 +294,8 @@ public void testNRTRestart() throws Exception { assertEquals(nrtCore, hostCore); // allow any exceptions to propagate jettyManipulationFuture.get(); + + // TODO what is expected here? why are we just bailing? Can't the following code just be removed... Review Comment: Removed in 869ee24dcfb1fbed253291d2f49945d186eaccda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org