noblepaul commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1109238520
##########
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##########
@@ -338,6 +338,7 @@ public void testNRTRestart() throws Exception {
start = new Date().getTime();
try {
do {
+ // TODO - What is expected here? equals not doing anything?
hostCore=?
Review Comment:
it should be this
```
if( pullCore.equals(
getHostCoreName(
COLL,
qaJettyBase,
client,
p -> {
p.set(CommonParams.Q, "id:345");
p.add("shards.preference", "replica.type:NRT");
}))){
done.set(true);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
