vinayakphegde commented on code in PR #1360: URL: https://github.com/apache/solr/pull/1360#discussion_r1108757653
########## solr/core/src/java/org/apache/solr/update/UpdateLog.java: ########## @@ -1940,7 +1940,12 @@ public void doReplay(TransactionLog translog) { ThreadLocal<UpdateRequestProcessor> procThreadLocal = ThreadLocal.withInitial( () -> { - var proc = processorChain.createProcessor(req, rsp); + UpdateRequestProcessor proc; + try { + proc = processorChain.createProcessor(req, rsp); + } catch (IOException e) { + throw new RuntimeException(e); + } Review Comment: or we can handle the exception in ClassificationUpdateProcessor's constructor itself. so that we don't have to propagate these changes everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org