magibney commented on PR #1360: URL: https://github.com/apache/solr/pull/1360#issuecomment-1433170936
No, the change results in never consulting the map at all; any caller of `SlowCompositeReaderWrapper.terms(String field)` will get a freshly-constructed (uncached) `Terms` instance. The caching is what allowed the `Terms` instances to "leak" across thread boundaries, so this change fixes the issue by removing caching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org