[
https://issues.apache.org/jira/browse/SOLR-16129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646243#comment-17646243
]
Chris M. Hostetter commented on SOLR-16129:
-------------------------------------------
I was never able to forcibly trigger the problem that this workaround/patch
attempted to address – and the folks who said they could reliably reproduce it
never replied back indicating if this patch improved the situation.
My vague understanding of the jetty fix is that it addresses a specific
situation that can trigger this kind of general problem - but that it's still
theoretically possible for some similar existing/future problem to cause
{{InputStreamResponseListener}} to hang.
In general I'm not a fan of code that "waits forever" w/o limit -- I'd
generally prefer a timeout we control would be useful for "future proofing"
against other bugs like this down the road.
But i may be wrong, and don't feel strongly about it.
> Solr specific InputStreamResponseListener to prevent client threads from
> hanging forever
> ----------------------------------------------------------------------------------------
>
> Key: SOLR-16129
> URL: https://issues.apache.org/jira/browse/SOLR-16129
> Project: Solr
> Issue Type: Improvement
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-16129.patch
>
>
> This issue tracks the implementation of workaround I suggested for SOLR-16099
> - it does not _fix_ the underlying bug (which as of this writting doesn't
> have an identified root cause) but it does ensure that client threads which
> encounter the bug won't hang forever...
> {quote}One thing we may want to consider (in Solr) is replacing our usage of
> {{InputStreamResponseListener}} with a variant implementation that uses a
> "timeout" instead of an unlimited {{wait()}} (along the lines of a [spin-off
> jetty enhancement issue|https://github.com/eclipse/jetty.project/issues/7259]
> one of the jetty devs filed). We could probably (with some effort) tweak the
> impacted Solr APIs to propogate the (remaining) {{timeAllowed}} (if that
> option was specified) down to this class – and/or have an "extreme" default
> (ie: 30min) just to prevent threads from sticking around forever.
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
